Skip to content

Conversation

@jgavris
Copy link
Contributor

@jgavris jgavris commented Sep 26, 2016

PR checklist

  • [ x ] Read the contribution guildelines.
  • [ x ] Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • [ x ] Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

  • Add thread-safe access to Alamofire Manager dictionary. Since we cannot assume the API client will always be invoked on the same thread.

@wing328
Copy link
Contributor

wing328 commented Sep 26, 2016

@jgavris thanks for the PR.

cc @Edubits @jaz-ah

@jaz-ah
Copy link
Contributor

jaz-ah commented Sep 26, 2016

+1 @wing328

@wing328
Copy link
Contributor

wing328 commented Sep 26, 2016

Tests look good. PR merged.

As always, thanks for the contribution.

@wing328 wing328 merged commit 0f25501 into swagger-api:master Sep 26, 2016
@jgavris jgavris deleted the swift-thread-safe-manager branch September 27, 2016 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants